Add IndexFlatIP, Range Search, and Reset features#4
Merged
Conversation
RangeSearchResult was only forward declared in Index.h, causing 'incomplete type' compilation error. Added #include <faiss/utils/Heap.h> to provide the complete type definition for RangeSearchResult. Note: If Heap.h doesn't exist in some FAISS installations, we may need to use a different approach or check the FAISS version.
anupammaurya6767
force-pushed
the
feature/add-flat-ip-range-search-reset
branch
from
a7d185a to
d51abb7
Compare
Heap.h doesn't contain the full RangeSearchResult definition in this FAISS version. Trying utils/distances.h which may contain range search utilities.
Heap.h and distances.h both failed. Trying AlignedTable.h which sometimes contains FAISS utility structures.
RangeSearchResult is defined in faiss/impl/AuxIndexStructures.h, not in utils/Heap.h or utils/distances.h. This is the correct header for RangeSearchResult definition in FAISS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features Added
Changes
Documentation